Added provider for closures of New York Stock Exchange (NYSE) since 2000.#382
Added provider for closures of New York Stock Exchange (NYSE) since 2000.#382mgwebgroup wants to merge 8 commits into
Conversation
#376) Without this, the holiday's name won't be translated. All other calculateHoliday() methods properly provide this argument, thus being translated. If you try this code: ```php $holiday = Yasumi::create(Brazil::class, 2025, 'pt_BR'); $this->assertEquals( 'Dia da Proclamação da República', $holiday->getHoliday(self::HOLIDAY)->getName() ); ``` It'll fail. Signed-off-by: Mateus Ribeiro Bossa <mateus.rbossa@gmail.com>
|
Thank you @mgwebgroup for this PR. You turned one of the code examples into a provider. Nice! Let me do a review this weekend. |
Signed-off-by: Art Kurbakov <admin@mgwebgroup.com>
Signed-off-by: Art Kurbakov <admin@mgwebgroup.com>
Signed-off-by: Art Kurbakov <admin@mgwebgroup.com>
Signed-off-by: Art Kurbakov <admin@mgwebgroup.com>
Signed-off-by: Art Kurbakov <admin@mgwebgroup.com>
stelgenhof
left a comment
stelgenhof
left a comment
There was a problem hiding this comment.
Looking good overall! The tests are failing unfortunately, and there are few small things that can be improved.
There was a problem hiding this comment.
Should this file be part of your PR?
There was a problem hiding this comment.
I grabbed it off of the develop branch when got started. Will remove from my PR.
| } | ||
| } | ||
|
|
||
| private function addEmergencies() |
There was a problem hiding this comment.
This method is missing a return type (void).
There was a problem hiding this comment.
Added void return type.
| } | ||
| } | ||
|
|
||
| private function addProclamations() |
There was a problem hiding this comment.
This method is missing a return type (void).
There was a problem hiding this comment.
Added void return type.
| ]; | ||
| } | ||
|
|
||
| private function addWeatherEvents() |
There was a problem hiding this comment.
This method is missing a return type (void).
There was a problem hiding this comment.
Added void return type.
Co-authored-by: Sacha Telgenhof <me@sachatelgenhof.com> Signed-off-by: Art Kurbakov <mgwebgroup@users.noreply.github.com>
Co-authored-by: Sacha Telgenhof <me@sachatelgenhof.com> Signed-off-by: Art Kurbakov <mgwebgroup@users.noreply.github.com>
|
I had to rebase the nyse-closures branch from commit c747552 so that src/Yasumi/Provider/Brazil.php is not included. |
|
@mgwebgroup If you still have your own branch, you could create a new PR again I think. |
#384) Added a holiday provider to track holidays and closures for the New York Stock Exchange. In addition to observed holidays, the closures include emergency, weather and presidential proclamation events since year 2000. Other US exchanges like NASDAQ and CBOE normally follow suit for holidays and closures. This PR supersedes PR #382. --------- Signed-off-by: Art Kurbakov <admin@mgwebgroup.com> Co-authored-by: Art Kurbakov <admin@mgwebgroup.com>
Added a holiday provider to track holidays and closures for the New York Stock Exchange. In addition to observed holidays, the closures include emergency, weather and presidential proclamation events since year 2000. Other US exchanges like NASDAQ and CBOE normally follow suit for holidays and closures. This PR supersedes PR #382. --------- Signed-off-by: Art Kurbakov <admin@mgwebgroup.com> Co-authored-by: Art Kurbakov <admin@mgwebgroup.com>
Added a holiday provider to track holidays and closures for the New York Stock Exchange. In addition to observed holidays, the closures include emergency, weather and presidential proclamation events since year 2000. Other US exchanges like NASDAQ and CBOE normally follow suit for holidays and closures. This PR supersedes PR #382. --------- Signed-off-by: Art Kurbakov <admin@mgwebgroup.com> Co-authored-by: Art Kurbakov <admin@mgwebgroup.com>
Added a holiday provider to track holidays and closures for the New York Stock Exchange. In addition to observed holidays, the closures include emergency, weather and presidential proclamation events since year 2000. Other US exchanges like NASDAQ and CBOE normally follow suit for holidays and closures. This PR supersedes PR azuyalabs#382. --------- Signed-off-by: Art Kurbakov <admin@mgwebgroup.com> Co-authored-by: Art Kurbakov <admin@mgwebgroup.com> Signed-off-by: Ján Hamrák <hamrak@kcorp.sk>
3 participants
Greetings to Azuyalabs!
I have added a holiday provider to track holidays and closures for the New York Stock Exchange. In addition to observed holidays, the closures include emergency, weather and presidential proclamation events since year 2000. Other US exchanges like NASDAQ and CBOE normally follow suit for holidays and closures.
Summary of changes:
The motivation of these changes is to provide good foundation for developers of trading packages to be able to determine availability of trading days.
Additional Notes:
Thank you for your time and consideration! I look forward to your review and comments.